Skip to content

fix: Add QEnum dtype inference#62

Merged
peshence merged 1 commit intomainfrom
fix/add-dtype-inference
Feb 5, 2026
Merged

fix: Add QEnum dtype inference#62
peshence merged 1 commit intomainfrom
fix/add-dtype-inference

Conversation

@HCookie
Copy link
Member

@HCookie HCookie commented Feb 5, 2026

Description

Add QEnum dtype inference
Closes #61

from qubed.value_types import QEnum

QEnum([0,1]).dtype == "int64"

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

🌈🌦️📖🚧 Documentation 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/dev-section/qubed/pull-requests/PR-62

@HCookie HCookie requested a review from mathleur February 5, 2026 13:10
@HCookie HCookie self-assigned this Feb 5, 2026
@HCookie HCookie added the enhancement New feature or request label Feb 5, 2026
@HCookie HCookie requested a review from peshence February 5, 2026 13:17
Copy link
Member

@mathleur mathleur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! @peshence, I think we might be able to change the FDB scanning script to avoid changing some of the types considering this?

Copy link
Collaborator

@peshence peshence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@peshence peshence merged commit 5e0e81d into main Feb 5, 2026
9 checks passed
@peshence peshence deleted the fix/add-dtype-inference branch February 5, 2026 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

QEnum assumes str as dtype

3 participants