Open
Conversation
…tructed by roxygen2
…ion to pass to mclapply
Owner
|
Thanks Noah, I have an update in flight (had been working offline, just update Github today) with a backwards compatible fix for SL.xgboost. I'll take a look at the other edits (and also working on moving SL.xgboost from using xgboost to xgb.train) |
Owner
|
xgboost update on CRAN now (had a hiccup with CLANG-ASAN error from the RandomForest package and had to modify some of the test scripts) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Eric,
I took it upon myself to make some edits to the package since the
xgboostupdate was creating some downstream issues for packages that depended onSuperLearner. I made thexgboostcode conform to the newly release version of the package on CRAN. I also made some updates to the documentation so that everything is in Roxygen2. I tested it withR CMD checkand it came up okay, but you might want to check it out for yourself before submitting it to CRAN. I would appreciate it if you could submit this to CRAN soon to ensure the packages that depend onSuperLearnercan stay up.Noah