Skip to content

Roxygen2 updates, xgboost fixes#157

Open
ngreifer wants to merge 15 commits intoecpolley:masterfrom
ngreifer:master
Open

Roxygen2 updates, xgboost fixes#157
ngreifer wants to merge 15 commits intoecpolley:masterfrom
ngreifer:master

Conversation

@ngreifer
Copy link
Contributor

Hi Eric,

I took it upon myself to make some edits to the package since the xgboost update was creating some downstream issues for packages that depended on SuperLearner. I made the xgboost code conform to the newly release version of the package on CRAN. I also made some updates to the documentation so that everything is in Roxygen2. I tested it with R CMD check and it came up okay, but you might want to check it out for yourself before submitting it to CRAN. I would appreciate it if you could submit this to CRAN soon to ensure the packages that depend on SuperLearner can stay up.

Noah

@ecpolley
Copy link
Owner

Thanks Noah, I have an update in flight (had been working offline, just update Github today) with a backwards compatible fix for SL.xgboost. I'll take a look at the other edits (and also working on moving SL.xgboost from using xgboost to xgb.train)

@ecpolley
Copy link
Owner

xgboost update on CRAN now (had a hiccup with CLANG-ASAN error from the RandomForest package and had to modify some of the test scripts)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants