Skip to content

Conversation

@markoceri
Copy link
Collaborator

This PR fixes #5 TypeScript compilation errors (TS6133: variable declared but never read) in several settings views where the v-for loop declared element variables that were not actually used in the template logic.

Previously, these TS6133 errors caused npm run build to fail, even though the underlying problem was only unused v-for variables.

Root cause

In the following views, the v-for used the pattern (item, i) but only the index i (or the backing store array) was effectively used, while the item variable was never read by TypeScript:

  • EnergyMonitorSettingsView: energyMonitor
  • ForecastProvidersSettingsView: forecastProvider
  • MinerControllersSettingsView: minerController

As a result, TypeScript reported TS6133 for each unused variable and the type-check step failed.

Changes

  • Updated src/views/settings/EnergyMonitorSettingsView.vue to avoid declaring an unused energyMonitor variable in the v-for and to bind the component via the actual value used.
  • Updated src/views/settings/ForecastProvidersSettingsView.vue to remove the unused forecastProvider variable from the v-for declaration or to use it consistently in bindings where appropriate.
  • Updated src/views/settings/MinerControllersSettingsView.vue to remove or properly use the minerController variable in the v-for loop.

The changes keep the runtime behavior of the UI intact while ensuring that all v-for variables are either used or not declared at all.

Result

  • TypeScript no longer emits TS6133 for these views.
  • npm run build completes successfully.
  • Code is more consistent with other settings views that correctly use v-for variables (e.g. energy sources, external services).

…der, and MinerController settings views to fix issue #5
@markoceri markoceri requested a review from sebailfico December 17, 2025 16:34
@markoceri markoceri added the bug Something isn't working label Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants