Open
Conversation
Added bearer-authorization and proxy-bearer-authorization.
When (and bearer-authorization basic-authorization) or
(and proxy-bearer-authorization proxy-basic-authorization)
an error is signaled.
Also added tests for error signalling and whether the authorization
value appears appropriately in the header.
Member
|
Is it substantially better than just using :additional-headers? |
Author
|
Bearer authorization is widespread nowadays, e.g. for oauth2 and api calls.
Adding new parameters makes it more convenient and less error prone (no typo in There is also a sanity check that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
bearer-authorizationandproxy-bearer-authorization.When
(and bearer-authorization basic-authorization)or(and proxy-bearer-authorization proxy-basic-authorization)an error is signaled.
Also added tests for error signalling and whether the authorization value appears appropriately in the header.