Skip to content

Enable ssl verification by default on supported implementations#80

Open
libre-man wants to merge 2 commits intoedicl:masterfrom
libre-man:ssl-verification
Open

Enable ssl verification by default on supported implementations#80
libre-man wants to merge 2 commits intoedicl:masterfrom
libre-man:ssl-verification

Conversation

@libre-man
Copy link

This should fix #70.

libre-man added 2 commits June 3, 2017 15:17
As most implementations can verify SSL certificates they should probably
do so. This also makes sure all checks that cl+ssl can do are done.
@avodonosov
Copy link
Contributor

avodonosov commented Jul 6, 2017

The new cl+ssl provides a more convenient way of doing verification than cl+ssl:ssl-check-verify-p. Also cl+ssl:ssl-check-verify-p is deprecated now.

#82 utilizes the new cl+ssl API.

#82 doesn't change the Drakma's default. But if Drakma needs to verify by default, after #82 is merged it would be enough to just change

 -                              verify
 +                              (verify :required)

in the drakma:http-request parameters declaration.

@stassats
Copy link
Member

Changing defaults is rarely a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update documentation to make *obvious* which platforms do not support certificate validation

3 participants