Add Double NAT test suite feature to main branch #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and fix compatibility between Double NAT and parallel system tests
Synchronize test-suite branch with main
…g and Double NAT features compatible
…t commands in documentation to reflect new syntax
ShadowJonathan
approved these changes
Oct 22, 2025
Collaborator
ShadowJonathan
left a comment
ShadowJonathan
left a comment
There was a problem hiding this comment.
LGTM, afgezien van kleine dingen, maar die kan je negeren
zeg maar als je m wil gemerge't hebben :)
Co-authored-by: Jonathan de Jong <jonathandejong02@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #93
The most significant changes in this pull request are described in CHANGELOG.md.
This pull request adds support for Double NAT in the test suite. However, this new feature is not fully compatible with the NAT hairpinning behaviour also implemented in the test suite. This seems to be a limitation of how NAT is implemented in the test suite; see #151 for more details.