Allow examiner scripts in packages and improve checks. #852
+149
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgemoralespou
approved these changes
Jan 21, 2026
Collaborator
jorgemoralespou
left a comment
jorgemoralespou
left a comment
There was a problem hiding this comment.
I think everything is ok, but there's one comment with potential conflict from examiner extensions.
| const test_program_directory_patterns = [ | ||
| "/home/eduk8s/workshop/examiner/tests", | ||
| "/opt/workshop/examiner/tests", | ||
| "/opt/packages/*/examiner/tests", |
Collaborator
There was a problem hiding this comment.
This could be provide for some confusion if multiple extensions provided same examiner test file_name, but I guess it's low probability.
Collaborator
Author
There was a problem hiding this comment.
That is part of why one can now put them in sub directories. So a package for Kubernetes can have test names prefixed by kubernetes/ where they would be located in /opt/packages/kubernetes/examiner/tests/kubernetes when unpacked.
This sort of conflict already existed due to it checking multiple directories. So was always a case of user beware.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My variant of improvements to examiner test script handling.
closes #837
closes #838
closes #847