[AU-2523] codespaces devstack collision port 2000 for frontend-app-learning#150
[AU-2523] codespaces devstack collision port 2000 for frontend-app-learning#150
Conversation
…gurations due to codespace port conflict
papphelix
changed the title
robrap
left a comment
robrap
left a comment
There was a problem hiding this comment.
- Let's ensure others are on the same page about the port change. (I'll help with that.)
- Then we can communicate out when we land this.
Thank you.
| | `frontend-app-learner-record`_ | http://localhost:1990/ | MFE (React.js) | Default | | ||
| +------------------------------------+-------------------------------------+----------------+--------------+ | ||
| | `frontend-app-learning`_ | http://localhost:2000/ | MFE (React.js) | Default | | ||
| | `frontend-app-learning`_ | http://localhost:2010/ | MFE (React.js) | Default | |
There was a problem hiding this comment.
I think we want a row with "Do not use. Reserved for Codespaces.", and http://localhost:2000/, to help ensure this doesn't happen again in the future.
There was a problem hiding this comment.
Added a row in rst table and added explanation on the same
…odespaces conflict
| * ``lms``: LMS, along with dependencies ``forum``, ``discovery``, ``Authn`` and some databases | ||
| * ``ecommerce``: Ecommerce, but also LMS as a dependency (for auth) | ||
| * ``cms+credentials``: Services can be combined to affect both at once | ||
| * **Reserved for Codespace**: The port `2000` is being used for github Codespace service & reserverd for Codespace use only. |
There was a problem hiding this comment.
| * **Reserved for Codespace**: The port `2000` is being used for github Codespace service & reserverd for Codespace use only. | |
| * **Reserved for Codespace**: The port `2000` is being used for github Codespace service & reserved for Codespace use only. |
| - edx.devstack.frontend-app-learning | ||
| ports: | ||
| - "2000:2000" | ||
| - "2010:2000" # avoid Codespaces port 2000 conflict |
There was a problem hiding this comment.
I think this comment and the notes in the rst doc are probably enough. I do not think we need to document this conflict for every usage of http://localhost:2010. We'll get an additional opinion before deciding either way, but it will be important to decide before making changes across repos.
| 'http://localhost:18400', # frontend-app-publisher | ||
| 'http://localhost:18450', # frontend-app-support-tools | ||
| 'http://localhost:2000', # frontend-app-learning | ||
| 'http://localhost:2010', # frontend-app-learning (port changed from 2000 to 2010, due to conflict in codepsace) |
There was a problem hiding this comment.
See earlier comment about whether or not we might drop all these redundant comment changes.
There was a problem hiding this comment.
- I got confirmation in Slack that we can remove these additional comments.
- Before this merges, we'll need to prep PRs for the following: https://github.com/search?q=org%3Aedx+localhost%3A2000++NOT+is%3Aarchived&type=code
- We'll also need a communication plan before we merge as well.
Thank you.
|
New solution has been provided for this hence closing this PR. |
3 participants
Due to github codespace mapping system port 2000 & had a collision with
make dev.upwe had to fix the ports forfrontend-app-learningfrontend-app-learningto 2010