fix: corrects naming of make_mako_template_dirs function#181
fix: corrects naming of make_mako_template_dirs function#181
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR corrects the naming of a function from _make_mako_template_dirs to make_mako_template_dirs across multiple files and documentation. The change removes the underscore prefix, indicating the function is no longer considered private.
- Updates function name references in comments and shell scripts
- Adds a new local theming directory path for edx development
- Ensures consistency across documentation and configuration files
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| py_configuration_files/lms.py | Updates commented function references and adds new theme directory path |
| provision-set-edx-theme.sh | Updates sed commands to match the new function name |
| docs/devstack_faq.rst | Updates documentation examples with correct function name |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
timmc-edx
left a comment
There was a problem hiding this comment.
Looks good, though the bot might be right about the comment change. (It does appear to be a properly documented public function now.)
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Yup, it's a good catch. Have updated. |
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This function was renamed from
_make_mako_template_dirstomake_mako_template_dirs.This also inherits the addition of a local theming directory used for edx development.
I've completed each of the following or determined they are not applicable: