fix: removed the docker images which are having no references#196
fix: removed the docker images which are having no references#196Akanshu-2u merged 2 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the chrome and firefox Docker containers and the associated vnc-passwords Makefile target from the devstack, as these services are no longer used or referenced within the edx organization.
- Removed chrome and firefox service definitions from docker-compose.yml
- Removed vnc-passwords Makefile target and updated .PHONY declaration
- Updated documentation to remove vnc-passwords reference
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docker-compose.yml | Removed chrome and firefox service definitions including container configurations, networking, ports, and volume mounts |
| Makefile | Removed vnc-passwords target and updated .PHONY declaration to exclude vnc-passwords |
| docs/devstack_interface.rst | Removed documentation entry for the vnc-passwords command |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
If we are removing the images are we also removing some other references to them ?
I found one for chrome and firefox :- https://github.com/edx/devstack/blob/master/options.mk#L93
Thanks Chintan for pointing it out. I have made the required removal from |
Description:
chromeandfirefoxdocker images which are having no references and usage inedxorg.vnc-passwordswhich we were receiving from respective containers.Private JIRA Link:
BOMS-196
Related PR: