forked from openedx/frontend-app-discussions
-
Notifications
You must be signed in to change notification settings - Fork 0
feat: added soft delete functionality #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Alam-2U
wants to merge
21
commits into
master
Choose a base branch
from
ealam/COMSO2-742
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
8711640
feat: added soft delete functionality
Alam-2U be1b649
Merge branch 'master' into ealam/COMSO2-742
Alam-2U f067565
feat: added soft delete functionality
Alam-2U c1c6e38
feat: added soft delete functionality
Alam-2U d348788
feat: added soft delete functionality
Alam-2U 8070247
Merge branch 'master' into ealam/COMSO2-742
Alam-2U e908403
feat: added soft delete functionality
Alam-2U 3e68d8b
feat: added soft delete functionality
Alam-2U 5744304
fix: new feature
chintanjoshi-apphelix-2u fd9406c
feat: added soft delete functionality
Alam-2U ebd6d13
feat: added soft delete functionality
Alam-2U 62b1e6f
feat: added soft delete functionality
Alam-2U ed1f949
fix: threads,response, comments in UI deleted content
chintanjoshi-apphelix-2u f595d2f
feat: added soft delete functionality
Alam-2U 24bd13d
feat: added soft delete functionality
Alam-2U 1da2d5e
feat: added soft delete functionality
Alam-2U cd4f4dd
fix: rectified the restore functionality
Alam-2U 2685f27
fix: add missing things for restore and fix counts
chintanjoshi-apphelix-2u 3381120
fix: added the unit tests
Alam-2U 94b4ad6
fix: UI link
chintanjoshi-apphelix-2u fb9d581
fix: copilot comments
Alam-2U File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The onClick handler on line 54 checks !isDeleted before calling the function, but the button is also disabled when isDeleted is true (line 55). This creates redundant protection. Either the disabled state is sufficient, or if you need the onClick check for some reason, document why both are necessary.