Closed
Conversation
Co-authored-by: abdullahwaheed <42172960+abdullahwaheed@users.noreply.github.com>
…edx#1700) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
openedx#1736) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…x#1739) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
BREAKING CHANGE: Pre-design-tokens theming is no longer supported. Co-authored-by: Diana Olarte <diana.olarte@edunext.co>
The commit adds eventlistener which picks up the autoAdvance message and triggers the next sequence. This has the same effect of clicking the next button. Signed-off-by: Farhaan Bukhsh <farhaan@opencraft.com>
Co-authored-by: abdullahwaheed <42172960+abdullahwaheed@users.noreply.github.com>
Co-authored-by: abdullahwaheed <42172960+abdullahwaheed@users.noreply.github.com>
…x#1713) * feat: remove waffle flags for managing course outline sidebar * fix: flag and tests * fix: product-tours tests * fix: remove default content for SequenceNavigationSlot and update tests * fix: remove default content for CourseBreadcrumbsSlot * fix: update plugin-slots version and documentation * revert: update plugin-slots version * fix: update tests
* test: remove snapshots and use rtl tests * test: add expected result on map search
* test: remove snapshots and use rtl tests * test: improve coverage on search results test
…date library version (openedx#1768)
…nedx#1763) * feat: use discount info endpoint for streak discount information * feat: pass course run key to discount code info call * feat: move changes behind a flag * fix: use async IIFE inside useEffect * fix: fix line length * fix: remove default value in dev * fix: improve coverage by adding conditional test based on env value * refactor: move logic inside function * refactor: move functions to utils * fix: ignore merge config
Bumps [js-toml](https://github.com/sunnyadn/js-toml) from 1.0.1 to 1.0.2. - [Release notes](https://github.com/sunnyadn/js-toml/releases) - [Commits](sunnyadn/js-toml@v1.0.1...v1.0.2) --- updated-dependencies: - dependency-name: js-toml dependency-version: 1.0.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v5) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 4 to 5. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@v4...v5) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: abdullahwaheed <42172960+abdullahwaheed@users.noreply.github.com>
Co-authored-by: abdullahwaheed <42172960+abdullahwaheed@users.noreply.github.com>
Co-authored-by: abdullahwaheed <42172960+abdullahwaheed@users.noreply.github.com>
Earlier versions of @openedx/frontend-build used on older version of 'sharp', which caused intermittent installation issues. The version of 'sharp' was updated in @openedx/frontend-build to fix these issues, so the frontend-build version can be updated here, to fix the issues in this project too. See openedx/frontend-build#664 and openedx/frontend-build#665 for more information. The frontend-build dependency was updated by: ``` npm install --package-lock-only @openedx/frontend-build ``` Private-ref: https://tasks.opencraft.com/browse/BB-9953
The previous implementation had a race condition that sometimes prevented XBlocks from being marked as viewed. Users had to scroll or resize the window to trigger visibility tracking instead of having it happen once content loads.
Co-authored-by: abdullahwaheed <42172960+abdullahwaheed@users.noreply.github.com>
Remove @edx/reactifex package from devDependencies as it is no longer needed. Translation extraction functionality has been verified to work correctly without this dependency. Co-Authored-By: Claude <noreply@anthropic.com>
Co-authored-by: abdullahwaheed <42172960+abdullahwaheed@users.noreply.github.com>
…9.2 (openedx#1803) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
….2 (openedx#1804) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* chore: bump frontend-component-header to v6.6.x * chore: bump frontend-component-header to ^8.0.0
Co-authored-by: abdullahwaheed <42172960+abdullahwaheed@users.noreply.github.com>
…enedx#1807) This commit installs version 2.23.1 of @edx/frontend-lib-learning-assistant. This release fixes a bug where the Xpert Learning Assistant was only available to learners in the audit and credit modes. See https://github.com/edx/frontend-lib-learning-assistant/releases/tag/v2.23.1.
Co-authored-by: abdullahwaheed <42172960+abdullahwaheed@users.noreply.github.com>
* feat: add plugin slot for content iframe error component * style: quality * fix: copilot suggestions
…den grades" label in the grade table (openedx#1797) Refactors the grade summary logic to delegate all calculation responsibilities to the backend. Previously, the frontend was performing grade summary computations using data fetched from the API. Now, the API itself provides the fully computed grade summary, simplifying the frontend and ensuring consistent results across clients. Additionally, a "Hidden Grades" label has been added in the grade summary table to clearly indicate sections where grades are not visible to learners. Finally, for visibility settings that depend on the due date, this PR adds a banner on the Progress page indicating that grades are not yet released, along with the relevant due date information.
Member
Author
|
I'm ignoring the |
There was a problem hiding this comment.
Pull request overview
This PR merges the openedx/release/ulmo branch into edx/release/teak, implementing a release cutover that includes significant architectural changes to the learning MFE. The changes focus on simplifying sidebar management, modernizing plugin slots, and refactoring test infrastructure.
Key Changes:
- Removes
enableNavigationSidebarandalwaysOpenAuxiliarySidebarfeature flags, making navigation sidebar always enabled - Refactors plugin slots to be empty by default, requiring explicit configuration to show default components
- Updates test infrastructure from
@edx/react-unit-test-utilsto React Testing Library - Enhances plugin slot documentation with detailed examples and prop descriptions
- Updates Node version from 20 to 24
Reviewed changes
Copilot reviewed 65 out of 75 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/setupTest.js |
Removes sidebar toggle options from test store initialization |
src/product-tours/ProductTours.test.jsx |
Simplifies test by removing unnecessary navigation interactions |
src/plugin-slots/UnitTitleSlot/index.jsx |
Hardcodes isEnabledOutlineSidebar to true, removes prop |
src/plugin-slots/SequenceNavigationSlot/index.jsx |
Removes default SequenceNavigation component from slot |
src/plugin-slots/CourseBreadcrumbsSlot/index.tsx |
Removes default CourseBreadcrumbs component from slot |
src/plugin-slots/*/README.md |
Adds comprehensive documentation with prop descriptions and examples |
src/plugin-slots/NotificationWidgetSlot/images/*.png |
Adds example screenshot for documentation |
src/courseware/data/thunks.js |
Removes sidebar toggle logic from course fetch |
src/courseware/data/api.js |
Updates API to only fetch completion tracking toggle |
src/courseware/course/sidebar/sidebars/course-outline/hooks.js |
Removes enableNavigationSidebar checks |
src/courseware/course/sequence/Unit/hooks/*.js |
Refactors from useKeyedState to React's useState |
src/courseware/course/sequence/Sequence.jsx |
Unconditionally renders sequence navigation slot |
.nvmrc |
Updates Node version from 20 to 24 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
Closing for now as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges in
openedx/release/ulmointoedx/release/teak