fix: Removing inappropriate argument flag#197
Merged
Conversation
ATLAS_EXTRA_SOURCES is just a list of source: destination arguments, and should not have had a named keyword.
There was a problem hiding this comment.
Pull request overview
This PR fixes the incorrect formatting of the ATLAS_EXTRA_SOURCES environment variable by removing the --repository= flag prefix. According to the PR description, ATLAS_EXTRA_SOURCES should contain a list of "source: destination" arguments without named keywords, unlike ATLAS_OPTIONS which uses named flags.
Changes:
- Removed
--repository=prefix fromATLAS_EXTRA_SOURCESassignments in edx-platform.Dockerfile - Removed
--repository=prefix fromATLAS_EXTRA_SOURCESassignments in credentials.Dockerfile (2 locations)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| dockerfiles/edx-platform.Dockerfile | Removes --repository= flag from ATLAS_EXTRA_SOURCES export in the translations stage |
| dockerfiles/credentials.Dockerfile | Removes --repository= flag from ATLAS_EXTRA_SOURCES in both base and dev stages |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
timmc-edx
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ATLAS_EXTRA_SOURCES is just a list of source: destination arguments, and should not have had a named keyword.