Skip to content

Episode/Series API changes and cleanups #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dkorunic wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Episode/Series API changes and cleanups #13

dkorunic wants to merge 2 commits into from

Conversation

@dkorunic
Copy link

@dkorunic dkorunic commented Mar 25, 2019

I'm sending this PR for further discussion and possible inclusion. Things done:

  • properly format (erroneous space before gomd.Init()) code in README
  • remove erroneous "/?" suffix in baseURL, as parameter/query builder will make sure we have proper URL format
  • refactor MovieByImdbID() to use query *QueryData as rest of the API, so that we can also provide Season and Episode in query, as per OMDB API (i permits Season and Episode parameters)
  • refactor requestAPI() for "id" and "t" accordingly, so that we also permit Season and Episode parameters in QueryData
  • fix invalid Errorf() format in TestInvalidCategory() and TestFailSearch()
  • refactor TestMediaByTitle() to add more tests and update for API changes, test Episode and Series queries
  • refactor TestMediaByImdbID() for API changes mentioned above and add new tests, namely Season and Episode searches

dkorunic added 2 commits March 19, 2019 10:41
@dkorunic
- Cleanup baseURL
4319c85 
- Extend QueryData to be able to use s and i queries with Season and
  Episode parameters
- Exnted MovieByImdbID() to include Season and Episode where
  appropriate,
- Refactor MovieByImdbID() to use QueryData as per standard API which
  also permits SearchType, Season and Episode filters
- Update unit tests for API changes
@dkorunic
Update docs in regards to 4319c85.
5f94d77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dkorunic