-
Notifications
You must be signed in to change notification settings - Fork 15
Add Neural Network Cleanup #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add Neural Network Cleanup #84
Conversation
|
Please separate this into multiple patches. The NN cleanup need to be linked to #81. But I can't do that when your PR is combining multiple changes. Please separate the patches into 3 pull requests: (1) The new file .github/workflow/build.yml duplicated with #79 |
|
Thanks a lot for the detailed feedback, Joseph really appreciate it. I will split this PR into multiple pull requests as suggested: -A PR for the NN cleanup (linked to #84) -A separate PR for the documentation improvements -I will drop the duplicated CI workflow change since it’s already covered in #79 Thanks again for pointing this out and for the guidance. |
|
Another suggestion, if you don't mind: Instead of calling the new function th_nn_deinit(), please use the name th_cleanup().
regards, |
|
Thanks for the suggestion, Joseph I have renamed th_nn_deinit() to th_cleanup() and updated all call sites accordingly. The new name is clearer and leaves room for future cleanup beyond NN-specific resources. Best regards, |
|
Merged to dev_2026q1 branch. |
##Summary
This PR addresses TODOs in the codebase by implementing proper memory cleanup for the neural network component and documenting magic numbers used for buffer padding.