Fix: Add missing NULL checks in mdf.c #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for this pull request. It looks fine to me. |
Contributor
|
Merged into dev branch (dev_2026q1). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR addresses a strict memory safety issue in
speex_echo_state_init_mcwhere internal buffer allocations were not being checked for failure.Changes:
Added NULL checks for all internal memory allocations (st->e, st->x, st->input, etc.) in
lib/speexdsp/libspeexdsp/mdf.cImplemented a proper cleanup mechanism: if any allocation fails,
speex_echo_state_destroyis called to free previously allocated memory, and NULL is returned.Updated speex_echo_state_destroy to safely handle NULL for st->fft_table to prevent crashes during error recovery.
Impact: Prevents potential null pointer dereferences and crashes in low-memory environments.
Related Issue: #82