Fix integer overflow check in multiply_frac #89
+4
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR replaces the fragile 32-bit overflow detection logic in
multiply_frac(inresample.c) with safer, standard 64-bit arithmetic.Changes:
multiply_fracupdated to cast operands tounsigned long longbefore multiplication.UINT32_MAX.Motivation:
The original code contained a TODO comment acknowledging the method was suboptimal:
/* TODO: Could use 64 bits operation to check for overflow. But only guaranteed in C99+ */. Since modern build environments support C99/64-bit integers, this change improves code safety and maintainability, ensuring that buffer sizes for the resampler are calculated correctly without wrapping.Related Issues: #88