-
Notifications
You must be signed in to change notification settings - Fork 0
Enhance Azure Modules: AzAPI Support, VM Options, and Storage Features #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lyudmililchev92
wants to merge
27
commits into
main
Choose a base branch
from
FW
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
b22d911
add optional key vault id
lyudmililchev92 188a48d
fix private key
lyudmililchev92 bc543ef
fix keys
lyudmililchev92 b46eb1b
fix virtual machine plan settings
lyudmililchev92 be88c16
add sku and sku tier to public ip
lyudmililchev92 a8b0d4a
add domain name label to public ip
lyudmililchev92 456128d
add availability set id
lyudmililchev92 94cb27c
fix availabiolity set
lyudmililchev92 7833df0
add platform fault domain count
lyudmililchev92 2497535
add minor change in network interface inside vms
lyudmililchev92 a9a3a38
add admin password to linux machines
lyudmililchev92 6ce1280
add admin password to linux vm
lyudmililchev92 92b1fb7
fix secret
lyudmililchev92 2ebb9ef
add versioning enabled for storage account
lyudmililchev92 bc2ebd3
add az api resource
lyudmililchev92 391863a
add azapi
lyudmililchev92 ef4742d
add version 2.5.0
lyudmililchev92 4fea05c
azapi
lyudmililchev92 2280567
fix
lyudmililchev92 cff971b
add azapi
lyudmililchev92 2f52558
fix azapi
lyudmililchev92 cde3df2
add providers
lyudmililchev92 8640623
fix pre commit
lyudmililchev92 03d27d0
remove unused file
lyudmililchev92 b8b6eee
add agreement
lyudmililchev92 2bfcc17
add one more source for vnet peerings
lyudmililchev92 7e63dcb
add custom to the validation
lyudmililchev92 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,3 +6,31 @@ resource "azurerm_storage_container" "main" { | |
|
|
||
| container_access_type = try(each.value.access_type, null) | ||
| } | ||
|
|
||
|
|
||
| resource "azapi_resource" "main" { | ||
| for_each = try(var.settings.api_containers, {}) | ||
lyudmililchev92 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| type = "Microsoft.Storage/storageAccounts/blobServices/containers@2023-05-01" | ||
| name = each.value.name | ||
| parent_id = "${azurerm_storage_account.main.id}/blobServices/default" | ||
| body = { | ||
| properties = { | ||
| defaultEncryptionScope = try(each.value.default_encryption_scope, "$account-encryption-key") | ||
| denyEncryptionScopeOverride = try(each.value.deny_encryption_scope_override, false) | ||
| immutableStorageWithVersioning = { | ||
| enabled = try(each.value.enable_versioning, true) | ||
| } | ||
| publicAccess = try(each.value.public_access, "None") | ||
| } | ||
| } | ||
| } | ||
|
|
||
|
|
||
| terraform { | ||
| required_providers { | ||
| azapi = { | ||
| source = "Azure/azapi" | ||
| } | ||
| } | ||
| } | ||
|
Comment on lines
+30
to
+36
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Define required providers in root module or where the rest of the providers have been defined.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. not work when I define them in the root module |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 6 additions & 0 deletions
6
src/modules/virtual_machines/linux_virtual_machine/agreement.tf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| resource "azurerm_marketplace_agreement" "main" { | ||
| count = try(var.settings.marketplace_agreement, null) == null ? 0 : 1 | ||
| publisher = var.settings.marketplace_agreement.publisher | ||
| offer = var.settings.marketplace_agreement.offer | ||
| plan = var.settings.marketplace_agreement.plan | ||
| } |
9 changes: 9 additions & 0 deletions
9
src/modules/virtual_machines/linux_virtual_machine/availability_set.tf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| resource "azurerm_availability_set" "main" { | ||
| count = try(var.settings.availability_set, null) == null ? 0 : 1 | ||
| name = try(var.settings.availability_set.name) | ||
| location = local.location | ||
| resource_group_name = local.resource_group_name | ||
| platform_fault_domain_count = try(var.settings.availability_set.platform_fault_domain_count, null) | ||
| platform_update_domain_count = try(var.settings.availability_set.platform_update_domain_count, null) | ||
| tags = local.tags | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
src/modules/virtual_machines/linux_virtual_machine/tls_private_key.tf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Какво е direction source, target, custom?