Safer array primitives #1220
Merged
Safer array primitives #1220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phischu
force-pushed
the
stdlib/safe_array
branch
2 times, most recently
from
0a92742 to
8b71915
Compare
Collaborator
Author
|
For some reason the stdlib tests go into an endless loop now. |
phischu
force-pushed
the
stdlib/safe_array
branch
from
d023732 to
2a11f6c
Compare
phischu
requested review from
jiribenes and
marzipankaiser
and removed request for
marzipankaiser
jiribenes
reviewed
Dec 11, 2025
| } | ||
|
|
||
| /// Allocate a new, empty dynamic array | ||
| /// Aallocatellocate a new, empty dynamic array |
| a.checkOutOfBounds(-1) | ||
| a.add(1) | ||
| a.add(2) | ||
| a.checkOutOfBounds(2) |
Contributor
There was a problem hiding this comment.
Can we somehow have a test for something like this, still? Even if just checking that it panics afterwards - for the resizable arrays, it might return the value at index 2 still (if capacity is >2) even if the length is just 2. And this might be hard to catch otherwise. 🤔
Contributor
There was a problem hiding this comment.
I'd personally be fine with the resizable arrays still using Exception[OutOfBounds] everywhere (and perhaps later a fail instead).
phischu
force-pushed
the
stdlib/safe_array
branch
from
38e9a79 to
94ec233
Compare
phischu
force-pushed
the
stdlib/safe_array
branch
from
94ec233 to
bcc6346
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.