Skip to content

fix: qualifier use over write #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akitaSummer wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: qualifier use over write #300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/core-decorator/src/util/QualifierUtil.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { MetadataUtil } from './MetadataUtil';
export class QualifierUtil {
static addProtoQualifier(clazz: EggProtoImplClass, attribute: QualifierAttribute, value: QualifierValue, isForceReplacement?: boolean) {
if (QualifierUtil.getQualifierValue(clazz, attribute) && !isForceReplacement) {
throw new Error(`Qualifier Error: clazz ${clazz.name} attribute ${attribute.toString()} has been implemented`);
console.warn(`Qualifier Warning: clazz ${clazz.name} attribute ${attribute.toString()} has been implemented`);
}
const qualifiers = MetadataUtil.initOwnMapMetaData(QUALIFIER_META_DATA, clazz, new Map<QualifierAttribute, QualifierValue>());
qualifiers.set(attribute, value);
Expand Down
2 changes: 1 addition & 1 deletion core/dynamic-inject/src/QualifierImplUtil.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import type { EggAbstractClazz, EggProtoImplClass, QualifierValue } from '@eggjs
export class QualifierImplUtil {
static addQualifierImpl(abstractClazz: EggAbstractClazz, qualifierValue: QualifierValue, implClazz: EggProtoImplClass, isForceReplacement?: boolean) {
if (QualifierImplUtil.getQualifierImp(abstractClazz, qualifierValue) && !isForceReplacement) {
throw new Error(`Qualifier Error: abstractClazz ${abstractClazz.name} qualifierValue ${qualifierValue.toString()} has been implemented`);
console.warn(`Qualifier Warning: abstractClazz ${abstractClazz.name} qualifierValue ${qualifierValue.toString()} has been implemented`);
}
const implMap = MetadataUtil.initOwnMapMetaData(QUALIFIER_IMPL_MAP, abstractClazz as unknown as EggProtoImplClass, new Map());
implMap.set(qualifierValue, implClazz);
Expand Down
Loading