Skip to content

fix: lifecycle for dns resolver initialization #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Dipper30 wants to merge 2 commits into from
Closed

fix: lifecycle for dns resolver initialization #389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0b8aaa
fix: lifecycle for dns resolver initialization
Dipper30 Jan 6, 2026
d8f7f97
Merge remote-tracking branch 'upstream/master' into fix/dns-cache-lif…
Dipper30 Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugin/dns-cache/app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,7 @@ export default class DnsCacheAppHook {
'[tegg-dns-cache-plugin] DNS cache is disabled, please setup dnsCache config.',
);
}
}

async configDidLoad() {
const config = this.app.config.dnsCache || {};

// Create DNS resolver instance
Expand All @@ -37,7 +35,9 @@ export default class DnsCacheAppHook {
const lookupFunction = this.dnsResolver.getLookupFunction();
this.app.config.httpclient = this.app.config.httpclient || {};
this.app.config.httpclient.lookup = lookupFunction;
}

async configDidLoad() {
// Add dnsResolver to app
this.app.dnsResolver = this.dnsResolver;
}
Expand Down
1 change: 0 additions & 1 deletion plugin/dns-cache/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@
"egg": ">=3.32.0"
},
"dependencies": {
"@eggjs/tegg": "^3.70.0",
"ylru": "^2.0.0"
},
"devDependencies": {
Expand Down
5 changes: 0 additions & 5 deletions plugin/dns-cache/test/fixtures/apps/dns_cache_lookup/config/plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,4 @@ exports.dnsCache = {
path: path.join(__dirname, '../../../../../'),
};

exports.teggController = {
package: '@eggjs/tegg-controller-plugin',
enable: true,
};

exports.watcher = false;
7 changes: 1 addition & 6 deletions plugin/dns-cache/test/fixtures/apps/dns_cache_lookup_http_next/config/plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,8 @@ exports.teggConfig = {
};

exports.dnsCache = {
path: path.join(__dirname, '../../../../../'),
enable: true,
};

exports.teggController = {
package: '@eggjs/tegg-controller-plugin',
enable: true,
path: path.join(__dirname, '../../../../../'),
};

exports.watcher = false;
5 changes: 0 additions & 5 deletions plugin/dns-cache/test/fixtures/apps/dns_cache_resolve/config/plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,4 @@ exports.dnsCache = {
path: path.join(__dirname, '../../../../../'),
};

exports.teggController = {
package: '@eggjs/tegg-controller-plugin',
enable: true,
};

exports.watcher = false;
Loading