fix: mcp proxy header #397
Conversation
Summary of ChangesHello @akitaSummer, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a potential compatibility issue with HTTP proxies by removing the explicit 'transfer-encoding: chunked' header from Server-Sent Events (SSE) responses. This ensures that SSE connections can reliably pass through various proxy configurations without encountering unexpected behavior or disconnections, thereby improving the robustness of real-time communication. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
📝 WalkthroughWalkthroughRemoved explicit Changes
Sequence Diagram(s)(omitted) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses an issue with MCP proxy headers by removing the transfer-encoding: 'chunked' header from Server-Sent Event (SSE) responses. This is a correct and important fix, as manually setting this header can cause issues with proxies and is generally redundant. The change is applied consistently across all relevant files. I've included a few suggestions to further improve code quality by extracting duplicated header objects into constants, which will enhance maintainability.
plugin/controller/test/fixtures/apps/mcp-app/hook-plugin/lib/MCPControllerHook.ts
Show resolved
Hide resolved
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@plugin/mcp-proxy/test/proxy.test.ts`:
- Around line 137-147: The assertion inside the fetch override for
StreamableHTTPClientTransport is too strict—replace the equality check on
res.headers.has('content-length') === !res.headers.has('transfer-encoding') with
a check that only verifies the two headers are not both present (i.e., allow
neither header), so update the assertion in the anonymous fetch override to
assert that !(res.headers.has('content-length') &&
res.headers.has('transfer-encoding')) using the same res.headers calls.
Checklist
npm testpassesAffected core subsystem(s)
Description of change
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.