fix: remove when_possible from eic_xl and eic_cuda #40
+0
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the 'concretizer: unify: when_possible' configuration from the xl/spack.yaml file. This setting was previously used to allow multiple epic versions, but is apparently no longer needed.
- Removes the concretizer configuration block from spack-environment/xl/spack.yaml
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
veprbl
previously approved these changes
Nov 17, 2025
Contributor
Author
Seems like eic_cuda had some other duplication. I'll have to see if it's bad or can be remedied. |
Removed the 'concretizer' configuration from spack.yaml.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
This PR removes the 'concretizer: unify: when_possible' configuration from spack.yaml for xl and cuda.
What kind of change does this PR introduce?