fix(md051): resolve false positive link fragment detection #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed bug where MD051 incorrectly flagged text patterns like "- [notalink] a (#491)" as invalid link fragments. The rule was manually parsing bracket/parenthesis patterns without properly validating markdown link structure. Changes: - Replace manual AST parsing with hybrid approach using tree-sitter "link" nodes + regex - Add proper validation to ensure only valid markdown links [text](url) are processed - Consolidate duplicate regex patterns into shared MARKDOWN_LINK_PATTERN for efficiency - Add comprehensive documentation explaining why tree-sitter alone isn't sufficient - Add test case for the specific bug scenario to prevent regression The fix ensures MD051 only processes legitimate markdown links while maintaining detection of all valid link fragment violations. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug where MD051 incorrectly flagged text patterns like "- [notalink] a (#491)" as invalid link fragments. The rule was manually parsing bracket/parenthesis patterns without properly validating markdown link structure.
Changes:
The fix ensures MD051 only processes legitimate markdown links while maintaining detection of all valid link fragment violations.
🤖 Generated with Claude Code