Commits from old repo and finished 2 TODOs#4
Open
AnonymousBluejay wants to merge 5 commits intoelBukkit:masterfrom
Open
Commits from old repo and finished 2 TODOs#4AnonymousBluejay wants to merge 5 commits intoelBukkit:masterfrom
AnonymousBluejay wants to merge 5 commits intoelBukkit:masterfrom
Conversation
This fixes a security vulnerability in this project where the `pom.xml` files were configuring Maven to resolve dependencies over HTTP instead of HTTPS. Signed-off-by: Jonathan Leitschuh <Jonathan.Leitschuh@gmail.com> Co-authored-by: Nathan Wolf <NathanWolf@users.noreply.github.com>
Author
|
Just realized the note about moving to fork probably isn't needed here |
Member
|
Thank you! So regarding the TODO:
Did you se and resolve the strange behavior? I honestly don't remember at all what was going on with this. |
Author
|
I'm not entirely sure where the original commented code came from, I just changed it to apply rotations in order. |
|
The original code on April 25, 2014 was: EffectLib/src/de/slikey/effectlib/util/VectorUtils.java Lines 37 to 42 in 316cba3 The experimental code and TODO were added the next day in bfb9bec already commented out, so it was never implemented. Hope that helps. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rotateVector() in VectorUtils may be a bit more optimized now
documented Nautilus particle