Open
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
🔍 Preview links for changed docs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similarly to what #3381 did, I added ESM support for hapi.
It seems many tests are migrating to
runTestFixtures, so I followed that while trying to preserve the spirit of previous tests, hopefully it covers as much.I had some problems with the Windows CI when combined with ESM, I activated debugging for require-in-the-middle, there were traces up to hapi's
lib/server.js, but I never sawlib/index.jsin those traces, so I'm not sure what's happening there, it doesn't seem related to my changes.I guess this contributes a bit to #3445, I don't see the point of adding hapi (unscoped) support since it's been deprecated a very long while ago.
Checklist
docs/release-notes/index.md