-
Notifications
You must be signed in to change notification settings - Fork 190
[Do not merge] Convert tabs that can be applies-switch #4429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
florent-leborgne
wants to merge
10
commits into
elastic:main
Choose a base branch
from
florent-leborgne:convert-tabs-into-applies-switch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Do not merge] Convert tabs that can be applies-switch #4429
florent-leborgne
wants to merge
10
commits into
elastic:main
from
florent-leborgne:convert-tabs-into-applies-switch
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Vale Linting ResultsSummary: 2 warnings, 38 suggestions found
|
| File | Line | Rule | Message |
|---|---|---|---|
| troubleshoot/elasticsearch/troubleshoot-migrate-to-tiers.md | 29 | Elastic.BritishSpellings | Use American English spelling 'toward' instead of British English 'towards'. |
| troubleshoot/elasticsearch/troubleshoot-migrate-to-tiers.md | 116 | Elastic.BritishSpellings | Use American English spelling 'toward' instead of British English 'towards'. |
💡 Suggestions (38)
| File | Line | Rule | Message |
|---|---|---|---|
| deploy-manage/users-roles/cluster-or-deployment-auth/saml.md | 425 | Elastic.Acronyms | 'PEM' has no definition. |
| troubleshoot/elasticsearch/add-tier.md | 29 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/add-tier.md | 74 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/allow-all-cluster-allocation.md | 27 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/allow-all-cluster-allocation.md | 81 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/allow-all-index-allocation.md | 30 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/allow-all-index-allocation.md | 83 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/decrease-disk-usage-data-node.md | 55 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/diagnose-unassigned-shards.md | 30 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/diagnose-unassigned-shards.md | 146 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/diagnosing-corrupted-repositories.md | 23 | Elastic.FutureTense | 'will entail' might be in future tense. Write in the present tense to describe the state of the product as it is now. |
| troubleshoot/elasticsearch/diagnosing-corrupted-repositories.md | 23 | Elastic.FutureTense | 'will keep' might be in future tense. Write in the present tense to describe the state of the product as it is now. |
| troubleshoot/elasticsearch/diagnosing-corrupted-repositories.md | 23 | Elastic.FutureTense | 'will be' might be in future tense. Write in the present tense to describe the state of the product as it is now. |
| troubleshoot/elasticsearch/diagnosing-corrupted-repositories.md | 60 | Elastic.FutureTense | 'will entail' might be in future tense. Write in the present tense to describe the state of the product as it is now. |
| troubleshoot/elasticsearch/fix-other-node-out-of-disk.md | 38 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/fix-other-node-out-of-disk.md | 38 | Elastic.FutureTense | 'will need' might be in future tense. Write in the present tense to describe the state of the product as it is now. |
| troubleshoot/elasticsearch/high-jvm-memory-pressure.md | 45 | Elastic.Acronyms | 'JVM' has no definition. |
| troubleshoot/elasticsearch/increase-capacity-data-node.md | 21 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/increase-capacity-data-node.md | 57 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/increase-capacity-data-node.md | 57 | Elastic.FutureTense | 'will need' might be in future tense. Write in the present tense to describe the state of the product as it is now. |
| troubleshoot/elasticsearch/increase-cluster-shard-limit.md | 29 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/increase-cluster-shard-limit.md | 81 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/increase-shard-limit.md | 29 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/increase-shard-limit.md | 82 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/increase-tier-capacity.md | 27 | Elastic.FutureTense | 'will increase' might be in future tense. Write in the present tense to describe the state of the product as it is now. |
| troubleshoot/elasticsearch/increase-tier-capacity.md | 139 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/repeated-snapshot-failures.md | 27 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/restore-from-snapshot.md | 27 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/restore-from-snapshot.md | 231 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/troubleshoot-migrate-to-tiers.md | 29 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/troubleshoot-migrate-to-tiers.md | 29 | Elastic.FutureTense | 'will resolve' might be in future tense. Write in the present tense to describe the state of the product as it is now. |
| troubleshoot/elasticsearch/troubleshoot-migrate-to-tiers.md | 29 | Elastic.FutureTense | 'will also' might be in future tense. Write in the present tense to describe the state of the product as it is now. |
| troubleshoot/elasticsearch/troubleshoot-migrate-to-tiers.md | 116 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/troubleshoot-migrate-to-tiers.md | 116 | Elastic.FutureTense | 'will resolve' might be in future tense. Write in the present tense to describe the state of the product as it is now. |
| troubleshoot/elasticsearch/troubleshoot-migrate-to-tiers.md | 116 | Elastic.FutureTense | 'will also' might be in future tense. Write in the present tense to describe the state of the product as it is now. |
| troubleshoot/observability/apm/apm-server-response-codes.md | 20 | Elastic.WordChoice | Consider using 'refer to (if it's a document), view (if it's a UI element)' instead of 'See', unless the term is in the UI. |
| troubleshoot/observability/apm/apm-server-response-codes.md | 24 | Elastic.WordChoice | Consider using 'refer to (if it's a document), view (if it's a UI element)' instead of 'See', unless the term is in the UI. |
| troubleshoot/observability/troubleshoot-logs.md | 49 | Elastic.WordChoice | Consider using 'refer to (if it's a document), view (if it's a UI element)' instead of 'see', unless the term is in the UI. |
Contributor
Author
|
Edit: found ittttt |
…-leborgne/docs-content into convert-tabs-into-applies-switch
Contributor
Contributor
|
@florent-leborgne , what kind of reviews do you want on this? It's not the typical PR so I'm just thinking about how best to go about it 🕵️ |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR converts tabs that should now be applies-switch thanks to the recent and upcoming updates to the metadata system.
This PR should only be merged after elastic/docs-builder#2322 is merged.
CI should fail until then.
Contributes to: #4361
Generative AI disclosure