-
Notifications
You must be signed in to change notification settings - Fork 204
Fix submodule handling in beats update job #11952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+36
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This pull request does not have a backport label. Could you fix it @swiatekm? 🙏
|
97458e8 to
65d7d85
Compare
c07d45d to
7f32e7a
Compare
Contributor
💔 Build Failed
Failed CI StepsHistory
cc @swiatekm |
Contributor
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
7f32e7a to
96d446e
Compare
96d446e to
6fbad53
Compare
ycombinator
reviewed
Dec 23, 2025
ycombinator
previously approved these changes
Dec 23, 2025
6fbad53 to
bdbd46e
Compare
mallendem
approved these changes
Dec 23, 2025
ycombinator
approved these changes
Dec 23, 2025
Contributor
|
@Mergifyio backport 9.1 9.2 9.3 |
Contributor
✅ Backports have been createdDetails
|
mergify bot
pushed a commit
that referenced
this pull request
Dec 23, 2025
* Fix submodule handling in beats update job * Drop unnecessary branch filtering in beats update (cherry picked from commit fc57a14)
mergify bot
pushed a commit
that referenced
this pull request
Dec 23, 2025
* Fix submodule handling in beats update job * Drop unnecessary branch filtering in beats update (cherry picked from commit fc57a14)
This was referenced Dec 23, 2025
mergify bot
pushed a commit
that referenced
this pull request
Dec 23, 2025
* Fix submodule handling in beats update job * Drop unnecessary branch filtering in beats update (cherry picked from commit fc57a14)
pierrehilbert
pushed a commit
that referenced
this pull request
Dec 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-active-9
Automated backport with mergify to all the active 9.[0-9]+ branches
chore
Tasks that just need to be done, they are neither bug, nor enhancements
skip-changelog
Team:Elastic-Agent-Control-Plane
Label for the Agent Control Plane team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use updatecli to bump beats versions in go.mod. Unfortunately, updatecli seems to have a problem dealing with updates to git submodules, and we treat beats as a submodule as of #11821. Instead, use updatecli to only change the files, and then use a separate action to create the PR.
See successful execution on this branch here: https://github.com/elastic/elastic-agent/actions/runs/20436029366. And the PR it created here: #11980.