[9.3] (backport #11813) Ingest collector internal telemetry via in-process hooks #11982
+11,061
−10,706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* internal telemetry drafting * monitoring config plumbing * Cleaning up / commenting for review * removing no-longer-used files * cleanup, testing * cleanup, pass through remaining config * remove debug placeholders * clean up receiver code layout * remove debug startup * Make check-ci * Fix formatting in go.mod for pdata dependency * review comments * lint * fix config field name * Move receiver package * Use more translate helpers * white space * add changelog * Disable the previous (prometheus) internal telemetry ingestion component * Lint, log errors * Add remaining translated metrics * fix typo * update tests * lint * add error log * mage check * mage notice * review comment * Stop integration tests from expecting a prometheus monitoring component * Move internal telemetry factory to same module as telemetry receiver * mage check * mage notice * test fixes * adjust default poll interval * add allowable monitoring errors * Adjust expected component count * Only include the otel monitoring receiver if the otel monitoring output is present * remove checks for prometheus-related log warnings * Replace empty test error with verbose failure details * remove duplicated lines * fix error log order --------- Co-authored-by: Pierre HILBERT <pierre.hilbert@elastic.co> (cherry picked from commit 7c84fc3)
mergify
bot
requested review from
michel-laterman and
swiatekm
and removed request for
a team
github-actions
bot
added
enhancement
Contributor
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
Contributor
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
Contributor
💔 Build Failed
Failed CI Steps
History
cc @faec |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a custom telemetry factory and receiver to the OTel collector build to support backwards-compatible ingestion of Collector metrics as ECS metrics that can be viewed in existing Agent dashboards (see #10220 for context on the prometheus-based approach this replaces).
Checklist
./changelog/fragmentsusing the changelog toolHow to test this PR locally
Running Agent with metrics monitoring enabled and any components using the OTel runtime, you should see collector metric data appear in the
metrics.elastic_agent*datastreams.Related issues
This is an automatic backport of pull request #11813 done by [Mergify](https://mergify.com).