Skip to content
This repository was archived by the owner on Oct 22, 2024. It is now read-only.

Conversation

@tmclaugh
Copy link

@tmclaugh tmclaugh commented Nov 7, 2013

The following PR adds a $json_conf parameter that can be toggled to create a JSON formatted lumberjack config. Setting it to true will alter how the $hostname and $files parameters work.

NOTE: This relies on a function called sorted_json() which I found as a gist on GitHub and no license. I've contacted the author regarding this. The functionality is unusable without this.
ref. https://gist.github.com/halkeye/2287885

Additionally, this PR fixes some other minor issues I ran into while testing my changes

  • An incorrect variable name in the lumberjack.erb file
  • /etc/lumberjack is now created by the module. (Our RPM did not do that.)
  • proper dependency handling in lumberjack::instance if $lumberjack::restart_on_change is false

tmclaugh referenced this pull request in danjung/puppet-lumberjack Nov 7, 2013
Otherwise you will not be able to create the /etc/lumberjack/${name} directory.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant