fix: paginate PR reviews #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VerteDinde
approved these changes
Jan 31, 2025
samuelmaddock
force-pushed
the
fix/paginate-prs
branch
from
6ab4f6a to
f2954c5
Compare
Member
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes cation not paginating all of the PR reviews in electron/electron#44411
I'm not sure whythere was a type conflict which resolved after updating dependenciesoctokit.paginateis having trouble with types as I'm doing the same as in zoilist's codehttps://github.com/electron/zoilist/blob/c3d2e49c58a8b2d5e8c84ec220ba3675a7cc29d8/src/remind.ts#L64-L68