fix: fix outlined button styles and improve their accessibility#1002
Open
nmggithub wants to merge 3 commits intoelectron:mainfrom
Open
fix: fix outlined button styles and improve their accessibility#1002nmggithub wants to merge 3 commits intoelectron:mainfrom
nmggithub wants to merge 3 commits intoelectron:mainfrom
Conversation
nmggithub
commented
Feb 1, 2026
Comment on lines
+205
to
+208
| // Docusaurus adds its own focus styles which we need to | ||
| // override here to avoid losing the outline. | ||
| // ref: https://github.com/electron/website/issues/1001 | ||
| body:not(.navigation-with-keyboard) &--outline:focus { |
Contributor
Author
There was a problem hiding this comment.
This isn't ideal, but Docusaurus is too board in their approach to hiding focus outlines when the user is using a mouse (I added a comment here in this issue to get the attention of their team: facebook/docusaurus#11314 (comment))
Contributor
Author
There was a problem hiding this comment.
The hook that requires this funky CSS by us has been removed upstream in Docusaurus (facebook/docusaurus#11713), but no new version has been released yet.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes #1001.
Checklist