Skip to content

Comments

Fix margins in showControls=false url param mode#3652

Open
toger5 wants to merge 4 commits intoelement-hq:livekitfrom
toger5:toger5/fix-margin-with-no-controls-SPA
Open

Fix margins in showControls=false url param mode#3652
toger5 wants to merge 4 commits intoelement-hq:livekitfrom
toger5:toger5/fix-margin-with-no-controls-SPA

Conversation

@toger5
Copy link
Contributor

@toger5 toger5 commented Jan 5, 2026

Test:

  • add showControls=false&header=none to the url params
  • start a call with this netlify build vs call.element.dev

before:

Screenshot 2026-01-09 at 13 52 03

after:
Screenshot 2026-01-09 at 13 51 57

Pulled out of #3638

@toger5 toger5 marked this pull request as ready for review January 5, 2026 21:03
@toger5 toger5 requested a review from a team as a code owner January 5, 2026 21:03
@toger5 toger5 requested a review from Half-Shot January 5, 2026 21:03
Copy link
Member

@robintown robintown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you consider broken about the current margins with controls hidden? This is what I see:

Screenshot From 2026-01-08 11-44-11

I'm not sure that we should make the footer take up as much empty space in this mode as it does normally, if the flag is for minimizing extra UI elements.

@toger5
Copy link
Contributor Author

toger5 commented Jan 9, 2026

This is what I see.
This is fairly old code I did not want to lose. I was not fully aware of the context when opening the PR.
Its about showControls=false&header=none
then it looks like this:
Screenshot 2026-01-09 at 13 40 20

@toger5
Copy link
Contributor Author

toger5 commented Jan 9, 2026

@robintown updated the impl. It does not work like this anymore due to the footer.hidden
(as i said really old code ;) )

@toger5 toger5 requested a review from robintown January 9, 2026 12:53
@toger5 toger5 added the PR-Bug-Fix Release note category. A PR that fixes a bug. label Jan 13, 2026
@toger5
Copy link
Contributor Author

toger5 commented Jan 16, 2026

This can get squashed merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Bug-Fix Release note category. A PR that fixes a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants