Skip to content

Remove not needed widget permissions #3721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
toger5 wants to merge 1 commit into
base: livekit
Choose a base branch
from
+15 −39
Draft

Remove not needed widget permissions #3721

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 14 additions & 26 deletions src/widget.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
import { getUrlParams } from "./UrlParams";
import { initializeWidget, widget } from "./widget";
import { Config } from "./config/Config";
import { ElementCallReactionEventType } from "./reactions";

Check failure on line 14 in src/widget.test.ts

View workflow job for this annotation

GitHub Actions / Lint, format & type check 

'ElementCallReactionEventType' is defined but never used

vi.mock("matrix-js-sdk", { spy: true });
const createRoomWidgetClientSpy = vi.mocked(createRoomWidgetClient);
Expand Down Expand Up @@ -52,17 +52,17 @@
expect(widget).toBeDefined();
expect(configInitSpy).toHaveBeenCalled();
const sendEvent = [
EventType.CallNotify, // Sent as a deprecated fallback
EventType.RTCNotification,
"org.matrix.msc4075.call.notify", // Sent as a deprecated fallback
"org.matrix.msc4075.rtc.notification",
];
const sendRecvEvent = [
"org.matrix.rageshake_request",
EventType.CallEncryptionKeysPrefix,
EventType.Reaction,
EventType.RoomRedaction,
ElementCallReactionEventType,
EventType.RTCDecline,
EventType.RTCMembership,
"io.element.call.encryption_keys",
"m.reaction",
"m.room.redaction",
"io.element.call.reaction",
"org.matrix.msc4310.rtc.decline",
"org.matrix.msc4143.rtc.member",
];

const sendState = [
Expand All @@ -74,26 +74,14 @@
stateKey,
}));
const receiveState = [
{ eventType: EventType.RoomCreate },
{ eventType: EventType.RoomName },
{ eventType: EventType.RoomMember },
{ eventType: EventType.RoomEncryption },
{ eventType: EventType.GroupCallMemberPrefix },
{ eventType: "m.room.create" },
{ eventType: "m.room.name" },
{ eventType: "m.room.member" },
{ eventType: "m.room.encryption" },
{ eventType: "org.matrix.msc3401.call.member" },
];

const sendRecvToDevice = [
EventType.CallInvite,
EventType.CallCandidates,
EventType.CallAnswer,
EventType.CallHangup,
EventType.CallReject,
EventType.CallSelectAnswer,
EventType.CallNegotiate,
EventType.CallSDPStreamMetadataChanged,
EventType.CallSDPStreamMetadataChangedPrefix,
EventType.CallReplaces,
EventType.CallEncryptionKeysPrefix,
];
const sendRecvToDevice = ["io.element.call.encryption_keys"];

expect(createRoomWidgetClientSpy.mock.calls[0][1]).toStrictEqual({
sendEvent: [...sendEvent, ...sendRecvEvent],
Expand Down
14 changes: 1 addition & 13 deletions src/widget.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,19 +142,7 @@ export const initializeWidget = (): void => {
{ eventType: EventType.GroupCallMemberPrefix },
];

const sendRecvToDevice = [
EventType.CallInvite,
EventType.CallCandidates,
EventType.CallAnswer,
EventType.CallHangup,
EventType.CallReject,
EventType.CallSelectAnswer,
EventType.CallNegotiate,
EventType.CallSDPStreamMetadataChanged,
EventType.CallSDPStreamMetadataChangedPrefix,
EventType.CallReplaces,
EventType.CallEncryptionKeysPrefix,
];
const sendRecvToDevice = [EventType.CallEncryptionKeysPrefix];

const client = createRoomWidgetClient(
api,
Expand Down
Loading