Prune sliding_sync_connection_required_state table
#19306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| required_state_id for _, _, required_state_id in room_config_rows | ||
| } | ||
|
|
||
| unused_required_state_ids = required_state_map.keys() - used_required_state_ids |
Contributor
There was a problem hiding this comment.
I think this is wrong 🤔
required_state_map.keys() will be things like the state event types requested.
used_required_state_ids is a bunch of required_state_id which is an auto-incrementing number.
| (connection_key, required_state_id) | ||
| for required_state_id in unused_required_state_ids | ||
| ], | ||
| ) |
Contributor
There was a problem hiding this comment.
Probably could use a test to sanity check the database looks fine after this runs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we change the
required_stateconfig for a room in sliding sync, we insert a new entry into thesliding_sync_connection_required_statetable. As the sliding sync connection advances we can accrue a lot of stale entries, so let's clear those out.This is a sort of follow on from #19211