Skip to content

Conversation

@teamcons
Copy link
Contributor

@teamcons teamcons commented Jun 9, 2025

Fixes #515
And a 11 years old bug: https://bugs.launchpad.net/elementaryos/+bug/1308876

Ctrl+S allows saving the playlist, but i am not sure how to expose it in the UI. I included it so half the support isnt in Needs Design Hell.

the implementation skip extended M3U flags. Meaning Extm3u playlists will still work.
URL will be skipped, so the coverage is alas not complete

when looping through the files and upon finding a m3u file in the list, Application.loop_through_files just call the support method that knows how to read m3u, and replace it with an array of all the files in it
it is then up to playback to check what in there actually exists

Saving M3U pretty much just loops through the queue to put it all in a file.

Copy link
Contributor

@zeebok zeebok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my testing, I saved a playlist from Music but it failed to open. I am going to look into it more because I am not sure if the issue is how it is saving or how it is loading.

@teamcons teamcons marked this pull request as draft August 4, 2025 10:48
teamcons and others added 4 commits August 4, 2025 12:49
Co-authored-by: Ryan Kornheisl <ryan@skarva.tech>
Co-authored-by: Ryo Nakano <ryonakaknock3@gmail.com>
Co-authored-by: Ryo Nakano <ryonakaknock3@gmail.com>
@teamcons
Copy link
Contributor Author

teamcons commented Aug 4, 2025

In my testing, I saved a playlist from Music but it failed to open. I am going to look into it more because I am not sure if the issue is how it is saving or how it is loading.

Hmmm.... It worked in my testing. I will test more cases/see if i can get issues

@teamcons teamcons reopened this Aug 5, 2025
teamcons and others added 2 commits August 15, 2025 21:52
Co-authored-by: Danielle Foré <danielle@elementary.io>
Co-authored-by: Danielle Foré <danielle@elementary.io>
@teamcons
Copy link
Contributor Author

My access to a PC will be very limited in the coming weeks, i will not be able to take care of this for a couple weeks

@teamcons teamcons marked this pull request as draft September 20, 2025 19:24
@teamcons teamcons marked this pull request as ready for review September 21, 2025 19:36
@teamcons teamcons requested a review from zeebok October 20, 2025 08:33
@ryonakano ryonakano self-requested a review October 26, 2025 01:51
teamcons and others added 3 commits October 26, 2025 21:43
Co-authored-by: Ryo Nakano <ryonakaknock3@gmail.com>
Co-authored-by: Ryo Nakano <ryonakaknock3@gmail.com>
@teamcons teamcons requested a review from danirabbit October 29, 2025 09:41
@teamcons
Copy link
Contributor Author

teamcons commented Oct 29, 2025

Vague thought but once this is merged, technically we could bin the whole "save/restore queue in dconf" and simply save/load from a m3u file in the data folder

That would avoid two separate code blocks for the same thing (less moving parts), and skip dumping shit of dubious length in dconf

maybe also not relying on dconf but straight up loading a file could also speed up recovery.

Saving the playlist only on app closing (or DE session disconnecting if the apps are allowed grace time) would also reduce disk writes and cpu usage

@teamcons
Copy link
Contributor Author

teamcons commented Dec 5, 2025

@danirabbit this has now conflicts because of the new QueueView branch being merged, despite sitting ready since months.
I will not resolve it. It is up to you if you want this.

It feels like another slap in the face.

});
}

public void action_save_m3u_playlist () {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like it should be an action in the playback manager, not in part of the UI

@danirabbit
Copy link
Member

@teamcons apologies. I hadn't kept up with this since when I was last reviewing it you had said you didn't have time to work on it and another reviewer had taken over since.

I think regardless this shouldn't be in a part of the UI. So resolving my next review comment would also be avoiding conflicts anyways

@teamcons
Copy link
Contributor Author

teamcons commented Dec 5, 2025

@teamcons apologies. I hadn't kept up with this since when I was last reviewing it you had said you didn't have time to work on it and another reviewer had taken over since.

image image image

I think regardless this shouldn't be in a part of the UI. So resolving my next review comment would also be avoiding conflicts anyways

you couldve flagged this last summer, about 5 month ago.
And if i do it, another random PR will go in at any point in the months of waiting and the whole discussion will begin anew

Im gonna spend the time on apps where it isnt pointless

@danirabbit
Copy link
Member

@teamcons My notifications are extremely full. I reviewed Leonhard's branch because it was a very easy review to do and it happened to be in my notifications when I had a free moment. It's nothing personal against you, just a matter of circumstance. I'm sorry that you feel demotivated, but I fear the expectations you've placed on me to prioritize reviewing your branches are not something I can live up to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ElementaryOS 5.0 Juno, Music app can't open .m3u files

4 participants