Skip to content

Handle "urgency" and "desktop-entry" hints in server #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danirabbit merged 5 commits into from
Nov 25, 2025
Merged

Handle "urgency" and "desktop-entry" hints in server #265

danirabbit merged 5 commits into from
Nov 25, 2025

Conversation

@lenemter
Copy link
Member

@lenemter lenemter commented Oct 5, 2025 •
edited
Loading

Almost the same as #210 but without image changes

This is a push to cleanup the Notification class to make it also usable with other server interfaces, hints are a exclusive concept of the Freedesktop's Notifications interface, and as such, it make more sense to deal with them in the server.

@lenemter lenemter requested a review from a team October 5, 2025 19:46
@lenemter lenemter added this to OS 8.1.0 Oct 6, 2025
@lenemter lenemter moved this to Needs review in OS 8.1.0 Oct 6, 2025
danirabbit
danirabbit approved these changes Nov 25, 2025
View reviewed changes
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense and looks good :)

@danirabbit danirabbit enabled auto-merge (squash) November 25, 2025 17:09
@danirabbit danirabbit merged commit 93fbe22 into main Nov 25, 2025
3 of 4 checks passed
@danirabbit danirabbit deleted the lenemter/move-some-hints-to-server branch November 25, 2025 17:18
@github-project-automation github-project-automation bot moved this from Needs review to Done in OS 8.1.0 Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danirabbit danirabbit danirabbit approved these changes

Assignees

No one assigned

Labels

None yet

Projects

No open projects
OS 8.1.0
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lenemter @danirabbit