Skip to content

Notification: create find_icon function #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danirabbit merged 7 commits into from
Nov 25, 2025
Merged

Notification: create find_icon function #285

danirabbit merged 7 commits into from
Nov 25, 2025

Conversation

@danirabbit
Copy link
Member

@danirabbit danirabbit commented Nov 21, 2025 •
edited
Loading

Fixes #284

Break out trying to find an app icon into a function:

  • Gets rid of some nesting
  • Make sure we group all the icon finding behavior
  • Actually check the icon theme to make sure icons exist
  • Always return an icon even if it's a fallback
  • Make primary_icon private set and no longer nullable

@danirabbit danirabbit requested a review from a team November 21, 2025 16:52
@danirabbit danirabbit moved this to Needs review in OS 8.1.0 Nov 21, 2025
@danirabbit danirabbit mentioned this pull request Nov 21, 2025
Merged
3 tasks
ryonakano
ryonakano reviewed Nov 25, 2025
View reviewed changes
@danirabbit danirabbit requested a review from ryonakano November 25, 2025 16:57
@danirabbit danirabbit enabled auto-merge (squash) November 25, 2025 21:27
@danirabbit danirabbit merged commit ab80833 into main Nov 25, 2025
7 of 8 checks passed
@danirabbit danirabbit deleted the danirabbit/find-icon branch November 25, 2025 21:27
@github-project-automation github-project-automation bot moved this from Needs review to Done in OS 8.1.0 Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leolost2605 leolost2605 leolost2605 left review comments

@ryonakano ryonakano ryonakano approved these changes

Assignees

No one assigned

Labels

None yet

Projects

No open projects
OS 8.1.0
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing, notification banner icon

4 participants

@danirabbit @ryonakano @leolost2605