Skip to content

Port to GTK 4 #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danirabbit merged 29 commits into from
Jan 12, 2024
Merged

Port to GTK 4 #377

danirabbit merged 29 commits into from
Jan 12, 2024

Conversation

@danirabbit
Copy link
Member

@danirabbit danirabbit commented Nov 16, 2023 •
edited
Loading

Closes #309

This was referenced Jan 9, 2024
Merged
Merged
@danirabbit danirabbit requested a review from a team January 10, 2024 19:14
@danirabbit danirabbit marked this pull request as ready for review January 10, 2024 19:14
@jeremypw
Copy link
Collaborator

jeremypw commented Jan 11, 2024

This seems to work pretty well. There are small differences in appearance such as font size and spacing between headers and secondary text. Should I assume these are intentional or will be addressed later?

@danirabbit
Copy link
Member Author

danirabbit commented Jan 12, 2024 •
edited
Loading

@jeremypw Yeah there's some changes with Granite.HeaderLabel so all the spacing and styling there is handled in Granite now. So yes it's intentional :)

@danirabbit danirabbit merged commit c11e4ab into master Jan 12, 2024
@danirabbit danirabbit deleted the danirabbit/gtk4 branch January 12, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeremypw jeremypw jeremypw approved these changes

Assignees

No one assigned

Labels

None yet

Projects

GTK4 Porting
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danirabbit @jeremypw