Skip to content

GTK4: Support .keyboard-activating class for buttons #1246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danirabbit merged 1 commit into from
Mar 13, 2023
Merged

GTK4: Support .keyboard-activating class for buttons #1246

danirabbit merged 1 commit into from
Mar 13, 2023

Conversation

@lenemter
Copy link
Member

@lenemter lenemter commented Mar 12, 2023

See https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/3390

I guess this class needs to be used in some other places, but this is bare minimum for elementary/calculator#242

@lenemter lenemter requested a review from a team March 12, 2023 22:58
@BAProductions
Copy link

BAProductions commented Mar 12, 2023

See https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/3390

I guess this class needs to be used in some other places, but this is bare minimum for elementary/calculator#242

We need to see if other UI Elements use .keyboard-activating as well & add it to the theme as needed.

@alice-mkh
Copy link
Contributor

alice-mkh commented Mar 13, 2023

No, it's a GtkButton thing.

@lenemter lenemter mentioned this pull request Mar 13, 2023
Open
@lenemter
Copy link
Member Author

lenemter commented Mar 13, 2023

Seems like more work needed to make this work with different styles. Converting to draft until issues resolved.

@lenemter lenemter self-assigned this Mar 13, 2023
@lenemter lenemter marked this pull request as draft March 13, 2023 03:57
@lenemter lenemter removed their assignment Mar 13, 2023
@lenemter lenemter marked this pull request as ready for review March 13, 2023 08:44
@lenemter
Copy link
Member Author

lenemter commented Mar 13, 2023

Seems like more work needed to make this work with different styles. Converting to draft until issues resolved.

The issue is in elementary/calculator#242.

Ready for review.

danirabbit
danirabbit approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh boy, that's interesting 😅 Thanks for the fix!

@danirabbit danirabbit merged commit a93cb4c into master Mar 13, 2023
@danirabbit danirabbit deleted the keyboard-activating-class branch March 13, 2023 15:43
BAProductions pushed a commit to MC-OS/stylesheet that referenced this pull request Mar 13, 2023
@lenemter @BAProductions
GTK3: Support .keyboard-activating class for buttons (elementary#1246)
90fa7b8
@BAProductions
Copy link

BAProductions commented Mar 14, 2023

This also apply to GTK3

@alice-mkh
Copy link
Contributor

alice-mkh commented Mar 14, 2023

No, it doesn't. GTK3 just uses the :active state for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danirabbit danirabbit danirabbit approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lenemter @BAProductions @alice-mkh @danirabbit