Skip to content

Conversation

@KasperZutterman
Copy link

This is a bugfix for Lokl - Docker hello-world cleanup - #16
Using docker info to check if Docker is running.

@leonstafford
Copy link
Contributor

Cheers, thanks for finding right repo!

My original intention with the hello-world was to lazily check that docker without sudo had enough permissions to launch an image.

I don't have a sudo requiring setup to check if this docker info will work as intended. Are you able to check?

Else, there's this automatically rm container after run:

docker run --rm hello-world...

If we can get away from that slow pulling and running of hello-world, would be nice improvement...

@KasperZutterman
Copy link
Author

Ah I see, I am unable to check if it runs without sudo on my Windows machine, unfortunately.

@leonstafford
Copy link
Contributor

@KasperZutterman no worries. We can do the rm thing for now and look into better (faster) options to test their Docker setup.

I had some exciting progress last night moving to new way of building. There's much less happening when you create a new container from the Lokl interactive script now - just this vs before, it would be doing some MySQL setup and WordPress installation. It does mean the initial Docker image that gets pulled down is a bit bigger (1.3GB vs 0.9GB), but can probably trim that down.

@leonstafford
Copy link
Contributor

(still not merged/published to main script on website yet. I've been developing the php8 image, but rearranging things so that we can choose either php7 or 8 in the interactive script)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants