-
Notifications
You must be signed in to change notification settings - Fork 19
Edit TesResources.java to add JSON fields #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- nextflow and plugin nf-ga4gh were failing to parse the JSON fields in the response from the TES server. - `Unrecognized field \"backend_parameters_strict\"` was the error message. - The solution was to add the JSON fields to the TesResources.java class.
Reviewer's Guide by SourceryThis pull request modifies the Updated class diagram for TesResourcesclassDiagram
class TesResources {
Long cpuCores
Double ramGb
Double diskGb
List~String~ zones
Map~String, String~ backendParameters
Boolean backendParametersStrict
}
note for TesResources "Added backendParameters and backendParametersStrict fields"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @trispera - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a unit test to verify the serialization and deserialization of the new fields.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
lvarin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Unrecognized field \"backend_parameters_strict\"was the error message.Summary by Sourcery
Bug Fixes: