Skip to content

fix: extension file uses the module_prefix option #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
yordis wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: extension file uses the module_prefix option #430

yordis wants to merge 2 commits into from

Conversation

@yordis
Copy link
Contributor

@yordis yordis commented Jan 27, 2026 •
edited
Loading

Compiling https://github.com/straw-hat-team/beam-monorepo/tree/master/apps/trogon_proto/lib/__generated__/trogon_proto I realized that the extensions aren't respecting the module_prefix

@yordis yordis force-pushed the fix-file-path branch 6 times, most recently from 49d8215 to 0b56cd5 Compare January 27, 2026 06:11
@yordis yordis marked this pull request as ready for review January 27, 2026 06:28
@yordis
Copy link
Contributor Author

yordis commented Jan 27, 2026

@whatyouhidedo you know why CI may be failing?

I am using:

elixir --version
Erlang/OTP 27 [erts-15.2.1] [source] [64-bit] [smp:14:14] [ds:14:14:10] [async-threads:1] [jit]

Elixir 1.18.2 (compiled with Erlang/OTP 27)

And it is working 😭

Screenshot 2026-01-27 at 1 46 23 AM

yordis
yordis commented Jan 27, 2026
View reviewed changes
test/test_helper.exs
[__DIR__, "../generated", relative_path]
|> Path.join()
|> File.read!()
base_path = [__DIR__, "../generated", relative_path] |> Path.join()
Copy link
Contributor Author

@yordis yordis Jan 27, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This made CI to pass 😭 Ideas welcomed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@yordis