Skip to content

makes url/delete in definition overridable #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ah0y wants to merge 2 commits into
base: master
Choose a base branch
from
Open

makes url/delete in definition overridable #50

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50a9f1d
makes url overridable
ah0y Jul 30, 2023
323732c
makes delete overridable
ah0y Jul 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/waffle_ecto/definition.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,8 @@ defmodule Waffle.Ecto.Definition do
url
else
case {url, updated_at} do
{nil, _} -> nil
{nil, _} ->
nil

{_, %NaiveDateTime{}} ->
version_url(updated_at, url)
Expand All @@ -81,11 +82,15 @@ defmodule Waffle.Ecto.Definition do

def url(f, v, options), do: super(f, v, options)

defoverridable [{:url, 3}]

def delete({%{file_name: file_name, updated_at: _updated_at}, scope}),
do: super({file_name, scope})

def delete(args), do: super(args)

defoverridable [{:delete, 1}]

defp version_url(updated_at, url) do
stamp = :calendar.datetime_to_gregorian_seconds(NaiveDateTime.to_erl(updated_at))

Expand Down