Add security checks and documentation for ECgFp5 operations #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added detailed documentation to ECgFp5 point and scalar field code, clarifying group law, canonical encoding, and security properties. Enforced canonical input checks in scalar multiplication and Montgomery multiplication, with panics on invalid input. Updated tests to verify rejection of non-canonical scalars and correct handling of canonical cases. Improved Schnorr signature documentation, emphasizing prime order, canonical encoding, and the absence of cofactor-related attacks.
lighter-zz
commented
Dec 24, 2025
lighter-zz
commented
Dec 24, 2025
| // SECURITY: Verify that 's' is canonical (< n) as required by Montgomery multiplication | ||
| if !s.IsCanonical() { | ||
| panic("MontyMul: first operand 's' must be canonical (< n)") | ||
| } |
Contributor
Author
There was a problem hiding this comment.
algorithmic changes here
lighterabc
approved these changes
Dec 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.