Skip to content

Adds Array.Extra.splice #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
gampleman wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adds Array.Extra.splice #64

gampleman wants to merge 1 commit into from

Conversation

@gampleman
Copy link
Collaborator

@gampleman gampleman commented Jul 25, 2024

Closes #22.

@gampleman gampleman requested review from lue-bird and miniBill July 25, 2024 21:33
@miniBill
Copy link
Collaborator

miniBill commented Jul 31, 2024

I wonder if a version based on Array.foldl would be faster or slower

lue-bird
lue-bird requested changes Jan 23, 2026
View reviewed changes
src/Array/Extra.elm
(Array.append (Array.slice 0 startIndex array)
(spliceFunction (Array.slice startIndex (startIndex + rc) array))
)
(Array.slice (startIndex + rc) (Array.length array) array)
Copy link
Collaborator

@lue-bird lue-bird Jan 23, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since startIndex can be negative, this slice start can get non-negative and therefore incorrectly add additional elements.

In general, tests would be cool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lue-bird lue-bird lue-bird requested changes

@miniBill miniBill Awaiting requested review from miniBill

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Array.Extra.splice

4 participants

@gampleman @miniBill @lue-bird