Conversation
Updated composer to allow install of psalm. Added the necessary psalm files for github actions.
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
|
@b-hayes Tagging you in this series of PRs for psalm. Sorry for the noise. Let us know if you think this is good to go as is or if the repo needs some special attention. Thanks! |
b-hayes
left a comment
b-hayes
left a comment
There was a problem hiding this comment.
I noticed there is no baseline file. Should be running vendor/bin/psalm --set-baseline for on these repos unless there was an executive decision not to do so.
Add the baseline for this repo
|
@b-hayes Added the baseline file. Let me know if we need anything else, thanks! |
b-hayes
left a comment
b-hayes
left a comment
There was a problem hiding this comment.
psalm workflow is failing.
Add jq fix for the baseline file
|
@b-hayes I have corrected the issue with the workflow run for this repo as well. Let me know if there is anything else to address! |
|
The compose.json has new requirements that are not dev. @joshmcrae care to comment on this? |
|
@b-hayes It depends why that dependency was added. If it can be moved into |
Remove the guzzle install as this was in an effort to resolve a rabbit hole issue on the below when just running a base composer install without tithely pay MacBook-Pro-4:omnipay-tithely anthonymenefee$ composer install php-http/discovery contains a Composer plugin which is currently not in your allow-plugins config. See https://getcomposer.org/allow-plugins Do you trust "php-http/discovery" to execute code and wish to enable it now? (writes "allow-plugins" to composer.json) [y,n,d,?]
|
@b-hayes and @joshmcrae you guys were right. I dug back through my history and it looks like I was down the rabbit hole on a composer issue from my side. I have removed those so we should be back to a clean composer. Let me know if anything is amiss. |
b-hayes
left a comment
b-hayes
left a comment
There was a problem hiding this comment.
I think we are good now.
3 participants
Updated composer to allow install of psalm. Added the necessary psalm files for github actions.