Skip to content

Ensured parametrised queries respect data types #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mr-Kaos wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ensured parametrised queries respect data types #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 26 additions & 2 deletions lib/PicoDb/StatementHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,12 +279,36 @@ protected function bindParams(PDOStatement $pdoStatement)
}

foreach ($this->positionalParams as $value) {
$pdoStatement->bindValue($i, $value, PDO::PARAM_STR);
switch (true) {
case is_numeric($value):
Copy link
Member

@joshmcrae joshmcrae May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is_numeric will return true if:

  • Value is a string containing a numeric value
  • Value is an int
  • Value is a float

Since PDO only has a param type for ints specifically and we want to allow int-only values in actual strings, is_int should be used here instead. This means floats and strings containing numeric values are still bound as strings.

$pdoStatement->bindValue($i, $value, PDO::PARAM_INT);
break;
case is_bool($value):
$pdoStatement->bindValue($i, $value, PDO::PARAM_BOOL);
break;
case $value === null:
$pdoStatement->bindValue($i, $value, PDO::PARAM_NULL);
break;
default:
$pdoStatement->bindValue($i, $value, PDO::PARAM_STR);
}
$i++;
}

foreach ($this->namedParams as $name => $value) {
$pdoStatement->bindValue($name, $value, PDO::PARAM_STR);
switch (true) {
case is_numeric($value):
$pdoStatement->bindValue($name, $value, PDO::PARAM_INT);
break;
case is_bool($value):
$pdoStatement->bindValue($name, $value, PDO::PARAM_BOOL);
break;
case $value === null:
$pdoStatement->bindValue($i, $value, PDO::PARAM_NULL);
break;
default:
$pdoStatement->bindValue($name, $value, PDO::PARAM_STR);
}
}
}

Expand Down