Make sure the right engine is available as _ when withImports is true#23
Open
demerzel3 wants to merge 1 commit intoemaphp:masterfrom
Open
Make sure the right engine is available as _ when withImports is true#23demerzel3 wants to merge 1 commit intoemaphp:masterfrom
_ when withImports is true#23demerzel3 wants to merge 1 commit intoemaphp:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix is a really small one, it just takes care of adding
_as the first imported symbol.For testing I had to actually load the generated module to check what was going on, so I had to add a couple of dependencies, hope you don't mind. Of course I'm open to suggestions and improvements.
Fixes #22