Add RFC for deprecation Ember Data initializers by bmac · Pull Request #181 · emberjs/rfcs

bmac · 2016-11-22T21:46:46Z

Known usage (checked for PR sent)

bc-ember-data-sails PR
- ./bc-ember-data-sails/addon/initializers/ember-data-sails.js: before: 'store',
- Last updated one year ago.
ember-data-complex PR
- ./ember-data-complex/addon/initializers/data-complex.coffee: before: 'store'
- Last updated two years ago
ember-data-model-fragments PR
- ./ember-data-model-fragments/app/initializers/model-fragments.js: before: "store",
ember-data-sails PR
- ./ember-data-sails/addon/initializers/ember-data-sails.js: before: 'store',
ember-fryctoria PR
- ./ember-fryctoria/addon/initializers/extend-ds-model.js: before: 'store',
- ./ember-fryctoria/addon/initializers/syncer.js: before: 'store',
- ./ember-parse/addon/initializers/parse.js: before: 'store',
ember-solr PR
- ./ember-solr/addon/initializers/solr.js: before: 'store',
- Last updated two years ago
ember-youtube-data-model PR
- ./ember-youtube-data-model/addon/initializers/youtube.coffee: before: 'store'
- Last updated two years ago

Todo

RFC - PR
- Submitted
- FCP
- Merged (pending FCP)
Deprecation Guide - PR
- Submitted
- Merged
- Updated (pending RFC)
Code change - PR
- Submitted
- Merged (pending RFC)

locks · 2016-11-30T13:18:31Z

text/0181-deprecate-ember-data-initializers.md

+`transforms`, and `store` Ember initializers that Ember Data injects
+into apps.  The `ember-data` initializer not be changed and any code
+that previously depended on the ordering of these initializers (via
+the `before` or `after` properties on an initalizer) will can be


"will can be changed"

locks · 2016-11-30T13:19:23Z

text/0181-deprecate-ember-data-initializers.md

+# Summary
+
+The goal of this RFC is to remove the `data-adapter`, `injectStore`,
+`transforms`, and `store` Ember initializers that Ember Data injects


possibly better to refer to them as application/application instance initializers?

locks · 2016-11-30T13:19:38Z

text/0181-deprecate-ember-data-initializers.md

+
+# Motivation
+
+The intializes `data-adapter`, `injectStore`, `transforms`, and


initializers

locks · 2016-11-30T13:20:00Z

text/0181-deprecate-ember-data-initializers.md

+`store` have not been used by Ember Data since
+[Apr 8, 2014](https://github.com/emberjs/data/commit/d25e23f622a3677b8372db535b2ab824ad306a16). However,
+they are still injected into every Ember app that depends on Ember
+Data because existing apps may have depending on these initializers


"may have depending"

locks · 2016-11-30T13:20:38Z

text/0181-deprecate-ember-data-initializers.md

+Data needs to support.
+
+Since these initializers are noop functions that run after the
+`ember-data` initializer. Any initializers that depends on one of the


comma instead of period?

locks · 2016-11-30T13:21:08Z

text/0181-deprecate-ember-data-initializers.md

+# Detailed design
+
+Ember Data's instance initializer will start checking for any
+initializers who's `before` or `after` properties depend on one of


locks · 2016-11-30T13:21:30Z

text/0181-deprecate-ember-data-initializers.md

+Ember Data's instance initializer will start checking for any
+initializers who's `before` or `after` properties depend on one of
+these deprecated initalizer. If it finds an initalizer that references
+one of the deprecated initalizers Ember Data will then log a


initializers,

locks · 2016-11-30T13:21:59Z

text/0181-deprecate-ember-data-initializers.md

+# How We Teach This
+
+This change should have no impact on how we teach Ember or Ember
+Data. The initalizers that will be remove have been unused for a long


"will be remove"

Muphry's law kicking in here ... "removed"

locks · 2016-11-30T13:22:21Z

text/0181-deprecate-ember-data-initializers.md

+removed.
+
+
+# How We Teach This


could we come up with a codemod?

locks · 2016-11-30T13:22:56Z

text/0181-deprecate-ember-data-initializers.md

+
+Users who need to run initalizer code before or after Ember Data
+injects the store into routes should be taught to use `before:
+'ember-data'`, or `after: 'ember-data'` on there initalizers.


initializers

locks · 2016-11-30T13:26:17Z

@bmac as done in https://github.com/cibernox/rfcs/blob/deprecate-ember-k/text/0000-deprecate-ember-k.md#addenda, I would like to suggestion reaching out to EmberObserver and get some usage statistics across published addons (worried about outdated dependencies), and coming up with a codemod, if possible. Looking good!

bmac · 2016-12-12T16:19:19Z

@locks I checked out all of the Ember Data Adapters and Ember Data Extensions form Ember observer and found the following adapters referencing the deprecated initializers.

./bc-ember-data-sails/addon/initializers/ember-data-sails.js:  before: 'store',
./ember-data-complex/addon/initializers/data-complex.coffee:  before: 'store'
./ember-data-model-fragments/app/initializers/model-fragments.js:  before: "store",
./ember-data-sails/addon/initializers/ember-data-sails.js:  before: 'store',
./ember-fryctoria/addon/initializers/extend-ds-model.js:  before:     'store',
./ember-fryctoria/addon/initializers/syncer.js:  before:     'store',
./ember-parse/addon/initializers/parse.js:  before: 'store',
./ember-solr/addon/initializers/solr.js:  before: 'store',
./ember-youtube-data-model/addon/initializers/youtube.coffee:  before: 'store'

bmac · 2016-12-12T16:30:30Z

text/0181-deprecate-ember-data-initializers.md

+
+The goal of this RFC is to remove the `data-adapter`, `injectStore`,
+`transforms`, and `store` Ember application initializers that Ember Data injects
+into apps.  The `ember-data` initializer not be changed and any code


"will not be changed"

locks · 2017-01-09T03:44:30Z

The Ember Data team has reviewed this proposal and have decided to move it to the Final Comment Period! If no new significant concerns are raised, in one week's time this proposal will be officially merged.
Thanks everyone for their work!

Add RFC for deprecation Ember Data initializers

919279f

bmac force-pushed the deprecate-ember-data-initializers branch from 230e0e4 to 919279f Compare November 22, 2016 21:47

bmac mentioned this pull request Nov 22, 2016

Deprecate unused initializers warp-drive-data/warp-drive#4657

Merged

1 task

locks requested changes Nov 30, 2016

View reviewed changes

Update the rfc based on pr feedback

81fe7e5

bmac mentioned this pull request Dec 12, 2016

Use the ember-data initializer as a target instead of the soon to b… huafu/ember-data-sails#39

Open

bmac commented Dec 12, 2016

View reviewed changes

Update 0181-deprecate-ember-data-initializers.md

0c24fab

locks mentioned this pull request Jan 5, 2017

Refer newer initializer in before. huafu/ember-data-sails#41

Closed

locks added the T-ember-data RFCs that impact the ember-data library label Jan 5, 2017

jenweber mentioned this pull request Jan 7, 2017

Add deprecation guide for ds.deprecated-initializers emberjs/website#2780

Closed

locks approved these changes Jan 8, 2017

View reviewed changes

locks added the Final Comment Period label Jan 9, 2017

igorT merged commit 8f302c7 into emberjs:master Jan 25, 2017


		# Motivation

		The intializes `data-adapter`, `injectStore`, `transforms`, and

Uh oh!

Comments

Conversation

bmac commented Nov 22, 2016 • edited by locks Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Known usage (checked for PR sent)

Todo

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

locks commented Nov 30, 2016

Uh oh!

bmac commented Dec 12, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

locks commented Jan 9, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bmac commented Nov 22, 2016 •

edited by locks

Loading